log esdb version periodically in the server logs

src/EventStore.Core.Tests/Fakes/FakeLogger.cs

@@ -0,0 +1,13 @@
+using System.Collections.Generic;
+using Serilog;
+using Serilog.Events;
+
+namespace EventStore.Core.Tests.Fakes;
+
+public class FakeLogger : ILogger {
+	public List<LogEvent> LogMessages { get; } = new();
+
+	public void Write(LogEvent logEvent) {
+		LogMessages.Add(logEvent);
+	}
+}

src/EventStore.Core.Tests/Services/PeriodicLogs/PeriodicallyLoggingServiceTests.cs

@@ -0,0 +1,54 @@
+using System;
+using System.Linq;
+using EventStore.Core.Messages;
+using EventStore.Core.Services.PeriodicLogs;
+using EventStore.Core.Services.TimerService;
+using EventStore.Core.Tests.Fakes;
+using NUnit.Framework;
+
+namespace EventStore.Core.Tests.Services.PeriodicLogs; 
+
+public class PeriodicallyLoggingServiceTests {
+
+	private FakePublisher _publisher;
+	private FakeLogger _logger;
+	private string _esVersion;
+
+	[SetUp]
+	public void SetUp() {
+		_publisher = new();
+		_logger = new FakeLogger();
+		_esVersion = "0.0.0.0";
+	}
+
+	[Test]
+	public void on_start() {
+		// given
+		var sut = new PeriodicallyLoggingService(_publisher, _esVersion, _logger);
+
+		// when
+		sut.Handle(new SystemMessage.SystemStart());
+
+		// then
+		Assert.IsInstanceOf<MonitoringMessage.CheckEsVersion>(_publisher.Messages.Single());
+		Assert.IsEmpty(_logger.LogMessages);
+	}
+
+	[Test]
+	public void log_es_version_periodically() {
+		// given
+		var sut = new PeriodicallyLoggingService(_publisher, _esVersion, _logger);
+
+		// when
+		sut.Handle(new MonitoringMessage.CheckEsVersion());
+
+		// then
+		var schedule = (TimerMessage.Schedule)_publisher.Messages.Single();
+		Assert.AreEqual(TimeSpan.FromHours(12), schedule.TriggerAfter);
+		Assert.IsInstanceOf<MonitoringMessage.CheckEsVersion>(schedule.ReplyMessage);
+
+		var logMessage = _logger.LogMessages.Single();
+		Assert.AreEqual($"Current version of Event Store is : \"0.0.0.0\" ", logMessage.RenderMessage());
+	} 
+
+}

src/EventStore.Core/ClusterVNode.cs

@@ -52,6 +52,7 @@
 using EventStore.Core.Caching;
 using EventStore.Core.Certificates;
 using EventStore.Core.Cluster;
+using EventStore.Core.Services.PeriodicLogs;
 using EventStore.Core.Synchronization;
 using EventStore.Core.TransactionLog.Checkpoint;
 using EventStore.Core.TransactionLog.FileNamingStrategy;
@@ -1536,6 +1537,9 @@ public class ClusterVNode<TStreamId> :
 				options.Cluster.DiscoverViaDns ? options.Cluster.ClusterDns : null);
 			_mainBus.Subscribe<SystemMessage.SystemReady>(_startup);
 			_mainBus.Subscribe<SystemMessage.BecomeShuttingDown>(_startup);
+			var periodicLogging = new PeriodicallyLoggingService(_mainQueue, VersionInfo.Version, Log);
+			_mainBus.Subscribe<SystemMessage.SystemStart>(periodicLogging);
+			_mainBus.Subscribe<MonitoringMessage.CheckEsVersion>(periodicLogging);
 
 			dynamicCacheManager.Start();
 		}

src/EventStore.Core/Messages/MonitoringMessage.cs

@@ -208,5 +208,9 @@ public partial class InternalStatsRequestResponse : Message {
 		[DerivedMessage(CoreMessage.Misc)]
 		public partial class DynamicCacheManagerTick : Message {
 		}
+
+		[DerivedMessage(CoreMessage.Misc)]
+		public partial class CheckEsVersion : Message {
+		}
 	}
 }

src/EventStore.Core/Services/Gossip/GossipServiceBase.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Net;
-using EventStore.Common.Log;
 using EventStore.Common.Utils;
 using EventStore.Core.Bus;
 using EventStore.Core.Cluster;
@@ -32,7 +31,6 @@ public abstract class GossipServiceBase : IHandle<SystemMessage.SystemInit>,
 		public static readonly TimeSpan GossipStartupInterval = TimeSpan.FromMilliseconds(100);
 		private readonly TimeSpan DeadMemberRemovalPeriod;
 		private static readonly ILogger Log = Serilog.Log.ForContext<GossipServiceBase>();
-		private static readonly ThrottledLog<GossipServiceBase> ThrottledLog = new(TimeSpan.FromHours(12));
 
 		protected readonly MemberInfo _memberInfo;
 		protected VNodeState CurrentRole = VNodeState.Initializing;
@@ -142,7 +140,6 @@ public abstract class GossipServiceBase : IHandle<SystemMessage.SystemInit>,
 			var gossipRound = Math.Min(int.MaxValue - 1, node == null ? message.GossipRound : message.GossipRound + 1);
 			_bus.Publish(
 				TimerMessage.Schedule.Create(interval, _publishEnvelope, new GossipMessage.Gossip(gossipRound)));
-			ThrottledLog.Information($"Current version of Event Store is : {_memberInfo.ESVersion}");
 		}
 
 		private MemberInfo GetNodeToGossipTo(MemberInfo[] members) {

src/EventStore.Core/Services/PeriodicLogs/PeriodicallyLoggingService.cs

@@ -0,0 +1,42 @@
+using System;
+using EventStore.Common.Utils;
+using EventStore.Core.Bus;
+using EventStore.Core.Messages;
+using EventStore.Core.Messaging;
+using EventStore.Core.Services.TimerService;
+using Serilog;
+
+namespace EventStore.Core.Services.PeriodicLogs;
+
+public class PeriodicallyLoggingService : 
+	IHandle<SystemMessage.SystemStart>,
+	IHandle<MonitoringMessage.CheckEsVersion> {
+
+	private static readonly TimeSpan _interval = TimeSpan.FromHours(12);
+
+	private readonly IPublisher _publisher;
+	private readonly string _esVersion;
+	private readonly ILogger _logger;
+	private readonly TimerMessage.Schedule _esVersionScheduleLog;
+
+	public PeriodicallyLoggingService(IPublisher publisher, string esVersion, ILogger logger) {
+		Ensure.NotNull(publisher, nameof(publisher));
+		Ensure.NotNull(logger, nameof(logger));
+
+		_publisher = publisher;
+		_esVersion = esVersion;
+		_logger = logger;
+		_esVersionScheduleLog = TimerMessage.Schedule.Create(_interval, new PublishEnvelope(publisher),
+			new MonitoringMessage.CheckEsVersion());
+	}
+
+	public void Handle(SystemMessage.SystemStart message) {
+		_publisher.Publish(new MonitoringMessage.CheckEsVersion());
+	}
+
+	public void Handle(MonitoringMessage.CheckEsVersion message) {
+		_logger.Information("Current version of Event Store is : {esVersion} ", _esVersion);
+		_publisher.Publish(_esVersionScheduleLog);
+	}
+
+}