Release lock during bad connection attempts

Release the lock which would normally be released as part of a callback if the call is made synchronously by invoking the delegate on the ThreadPool. This code likely needs more attention as it's quite convoluted.
EventStore · Mar 7, 2015 · 31c0ca8 · 31c0ca8
1 parent a281b10
commit 31c0ca8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/EventStore.ClientAPI/Transport.Tcp/TcpConnection.cs b/src/EventStore.ClientAPI/Transport.Tcp/TcpConnection.cs
@@ -33,12 +33,12 @@ internal class TcpConnection : TcpConnectionBase, ITcpConnection
                                   {
                                       connection.InitSocket(socket);
                                       if (onConnectionEstablished != null)
-                                          onConnectionEstablished(connection);
+                                          ThreadPool.QueueUserWorkItem(o => onConnectionEstablished(connection));
                                   },
                                   (_, socketError) =>
                                   {
                                       if (onConnectionFailed != null)
-                                          onConnectionFailed(connection, socketError);
+                                          ThreadPool.QueueUserWorkItem(o => onConnectionFailed(connection, socketError));
                                   }, connection, connectionTimeout);
 // ReSharper restore ImplicitlyCapturedClosure
             return connection;
@@ -356,4 +356,4 @@ public override string ToString()
             return RemoteEndPoint.ToString();
         }
     }
-}
+}
diff --git a/src/EventStore.ClientAPI/Transport.Tcp/TcpConnectionSsl.cs b/src/EventStore.ClientAPI/Transport.Tcp/TcpConnectionSsl.cs
@@ -33,12 +33,12 @@ internal class TcpConnectionSsl : TcpConnectionBase, ITcpConnection
                                   {
                                       connection.InitClientSocket(socket, targetHost, validateServer);
                                       if (onConnectionEstablished != null)
-                                          onConnectionEstablished(connection);
+                                          ThreadPool.QueueUserWorkItem(o => onConnectionEstablished(connection));
                                   },
                                   (_, socketError) =>
                                   {
                                       if (onConnectionFailed != null)
-                                          onConnectionFailed(connection, socketError);
+                                          ThreadPool.QueueUserWorkItem(o => onConnectionFailed(connection, socketError));
                                   }, connection, connectionTimeout);
             // ReSharper restore ImplicitlyCapturedClosure
             return connection;
@@ -434,4 +434,4 @@ public override string ToString()
             return "S" + RemoteEndPoint;
         }
     }
-}
+}