this change seems safe as the two should be equivalent.and it doesnt

create an array on each
EventStore · Mar 1, 2014 · 3a62071 · 3a62071
1 parent 6635977
commit 3a62071
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/src/EventStore/EventStore.Core/Index/Hashes/Murmur2Unsafe.cs b/src/EventStore/EventStore.Core/Index/Hashes/Murmur2Unsafe.cs
@@ -42,10 +42,9 @@ public class Murmur2Unsafe: IHasher
 
         public unsafe UInt32 Hash(string s)
         {
-            var data = s.ToCharArray();
+            fixed (char* input = s)
-            fixed (char* input = &data[0])
             {
-                return Hash((byte*)input, (uint)data.Length * sizeof(char), Seed);
+                return Hash((byte*)input, (uint)s.Length * sizeof(char), Seed);
             }
         }
 

diff --git a/src/EventStore/EventStore.Core/Index/Hashes/Murmur3AUnsafe.cs b/src/EventStore/EventStore.Core/Index/Hashes/Murmur3AUnsafe.cs
@@ -1,4 +1,4 @@
-// Copyright (c) 2012, Event Store LLP
+// Copyright (c) 2014, Event Store LLP
 // All rights reserved.
 // 
 // Redistribution and use in source and binary forms, with or without
@@ -38,10 +38,9 @@ public class Murmur3AUnsafe : IHasher
 
         public unsafe UInt32 Hash(string s)
         {
-            var data = s.ToCharArray();
+            fixed (char* input = s)
-            fixed (char* input = &data[0])
             {
-                return Hash((byte*)input, (uint)data.Length * sizeof(char), Seed);
+                return Hash((byte*)input, (uint)s.Length * sizeof(char), Seed);
             }
         }
 

diff --git a/src/EventStore/EventStore.Core/Index/Hashes/XXHashUnsafe.cs b/src/EventStore/EventStore.Core/Index/Hashes/XXHashUnsafe.cs
@@ -1,4 +1,4 @@
-// Copyright (c) 2012, Event Store LLP
+// Copyright (c) 2014, Event Store LLP
 // All rights reserved.
 // 
 // Redistribution and use in source and binary forms, with or without
@@ -41,10 +41,9 @@ public class XXHashUnsafe: IHasher
 
         public unsafe UInt32 Hash(string s)
         {
-            var data = s.ToCharArray();
+            fixed (char* input =s)
-            fixed (char* input = &data[0])
             {
-                return Hash((byte*) input, (uint) data.Length*sizeof (char), Seed);
+                return Hash((byte*) input, (uint) s.Length*sizeof (char), Seed);
             }
         }