Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of __MonoCS__ #1159

Merged
merged 1 commit into from Jan 13, 2017
Merged

Get rid of __MonoCS__ #1159

merged 1 commit into from Jan 13, 2017

Conversation

gregoryyoung
Copy link
Contributor

@gregoryyoung gregoryyoung commented Jan 5, 2017

Replaced with existing USE_UNIX_IO and MONO for other places.
Also added a few MONOCKECK comments where we should follow up if it
is still needed or not fixes #1157

Copy link
Contributor

@pgermishuys pgermishuys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Replaced with existing USE_UNIX_IO and MONO for other places.
Also added a few MONOCKECK comments where we should follow up if it
is still needed or not
@gregoryyoung
Copy link
Contributor Author

Seems reasonable and no dependency now. That code will just dissappear with unbuffered

@pgermishuys pgermishuys merged commit 7fd0143 into release-v4.0.0 Jan 13, 2017
@pgermishuys pgermishuys deleted the monocs branch January 13, 2017 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants