Commit count from master can come last #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the cases where the commit ack from master comes last, the awaiting commit count can drop below 0 because in a 3 node cluster for example, the awaiting commit count is equal to 2. If you get the master ack last, the condition for a successful write won't be hit as the commit count will be lower than 0
pgermishuys
pushed a commit
that referenced
this pull request
Aug 4, 2017
Prepare count from master can come last
pgermishuys
pushed a commit
that referenced
this pull request
Aug 4, 2017
Prepare count from master can come last
hayley-jean
changed the title
pgermishuys
pushed a commit
that referenced
this pull request
Aug 10, 2017
Prepare count from master can come last
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases where the commit ack from master comes last, the awaiting commit count can drop below 0 because in a 3 node cluster for example, the awaiting commit count is equal to 2. If you get the master ack last, the condition for a successful write won't be hit as the commit count will be lower than 0