Convert projects to .NET SDK Format #1710

jen20 · 2018-08-27T19:16:18Z

This is intended to supersede #1703 and add in the changes necessary to get our current CI process going again. It may take in some other PRs over time too.

jen20 · 2018-08-27T19:16:29Z

cc @jageall

enricosada

some feedback, using default and .net core sdk (instead of mono to compile) make it a lot easier to upgrade later to multitargeting

enricosada · 2018-09-04T15:08:30Z

build.sh

@@ -222,7 +222,13 @@ function buildEventStore {
    patchVersionFiles
    patchVersionInfo
    rm -rf bin/
-    xbuild src/EventStore.sln /p:Platform="Any CPU" /p:DefineConstants="$DEFINES" /p:Configuration="$CONFIGURATION" || err
+    msbuild \


you can use .net core sdk to build also net461.
so in the build script you can use dotnet build, dotnet pack, etc. who are easier to use (and same command line experience for users).

That also mean you dont need to use msbuild of mono for compiling, so you can use mono just as runtime.
It make it easier to upgrade (the .net sdk can be installed side by side, easier to upgrade and pin with a global.json)

Hi @enricosada! Thanks for looking over this and providing feedback. We're actually using dotnet msbuild at the moment internally, but the build scripts are due for a rewrite once the rest of the cleanup work is done, so that hasn't been ported into the old ones yet (the change you are commenting on will not be in the eventual version of this pull request).

The only slightly weird thing appears to be that to build with Mono it is necessary to set FrameworkPathOverrides (or something similar, I forget the exact variable and am on a Windows box right now so don't have it in history).

Ultimately we want to fit into the "standard" .NET workflow as much as possible given the native dependencies.

enricosada · 2018-09-04T15:10:06Z

src/EventStore.Rags.Tests/EventStore.Rags.Tests.csproj

+    <TargetFramework>net46</TargetFramework>
+    <Platform>x64</Platform>
+    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
+    <OutputPath>..\..\bin\tests\</OutputPath>


that make a lot harder to run dotnt test with multitargeting (useful later to test both net461 and netcoreapp)

using dontet test is easier also from command line and build scripts, no need to use custom test runner

This is mostly legacy from the current build scripts, and will be changed as per your comment.

enricosada · 2018-09-04T15:10:29Z

src/EventStore.Rags.Tests/EventStore.Rags.Tests.csproj

+    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
+    <OutputPath>..\..\bin\tests\</OutputPath>
+    <DebugSymbols>true</DebugSymbols>
+    <DebugType>full</DebugType>


new mono support portable too

Oh, interesting - we should likely switch to use that.

enricosada · 2018-09-04T15:11:52Z

src/EventStore.Projections.Core/EventStore.Projections.Core.csproj

-    <Optimize>false</Optimize>
+    <TargetFramework>net46</TargetFramework>
+    <Platform>x64</Platform>
+    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
    <OutputPath>..\..\bin\intermediate\</OutputPath>


doing like that make use of multitargeting a lot harder later.
new sdk use bin/{Configuration}/{tfm} to make it easier to do incremental build

👍 - This is left over from the previous build script set and was ported over - it should be fixed reasonably shortly.

jen20 · 2018-09-04T17:25:23Z

Thanks for the feedback @enricosada! As the replies to individual comments hopefully show, you've caught things in an intermediate state right now - we're moving in the direction that you are advocating for and will be there before this is merged.

Right now there are a few other pieces of cleanup to do first in order to remove compile-time platform detection, and then I'm going to fix up these bits.

enricosada · 2018-09-04T17:51:08Z

@jen20 sure! 👍 to the work

Removes some files not included in the existing projects - EventStore.Core.Tests/Index/IndexV3/table_index_hash_collision_when_upgrading_to_64bit.cs - EventStore.Projections.Core.Tests/ClientAPI/when_handling_created/with_from_all_any_foreach_projection/when_running_and_events_are_indexed.cs - EventStore.Projections.Core.Tests/ClientAPI/when_handling_deleted/with_from_all_any_foreach_projection/when_running_and_events_are_indexed.cs - EventStore.TestClient/Commands/RunTestScenarios/ProjGenerateSampleData.cs - EventStore.TestClient/Commands/RunTestScenarios/ProjectionsScenario1.cs

This commit uses msbuild in preference to xbuild on *nix systems. We also call the restore target prior to the compile target.

- moved Eventstore.Rags under src - dependencies are now pulled from myget feed

- Pin version of mono to be installed to 5.16 on OS X - Pin version of mono to be installed to 5.16 on Centos 7 image Co-authored-by: Avish Cheetaram <avishcheetaram.ai@gmail.com>

…e timeouts on EmbeddedClient

…to concurrent access issues when EmbeddedClient subscribes to the node's MainBus) This should not cause any performance issue since subscribing/unsubscribing is usually only done at initialization/shutdown time.

…3 = 24s, queryTimeout = 20s)

Add links to projection library build instructions Add instructions to build UI Add Azure Pipelines status badge Remove outdated information

jen20 self-assigned this Aug 27, 2018

jen20 requested a review from shaan1337 August 27, 2018 19:16

jen20 mentioned this pull request Aug 28, 2018

Add appveyor.yml for CI builds #1709

Merged

shaan1337 mentioned this pull request Aug 29, 2018

Add a new property CmdDefineConstants that's appended to DefineConstants in all csproj files under EventStore.sln #1707

Merged

This was referenced Aug 30, 2018

The .NET Core MegaThread(TM) #1716

Closed

Updates the project format to the new sdk style format #1703

Closed

Upgrade nunit console to 3.8.0 #1711

Closed

Include units. #1720

Closed

enricosada reviewed Sep 4, 2018

View reviewed changes

jen20 mentioned this pull request Sep 5, 2018

Questions: Event Store 4.0 for OSX & Mono #1269

Closed

jen20 force-pushed the new-project-format branch from d257431 to 071e8dc Compare September 7, 2018 15:30

This was referenced Sep 9, 2018

Remove AutoResetEvent based queues #1721

Closed

Fixing macOS build #1723

Closed

Giving the correct reason when the subscription drops due to overflow #1728

Merged

This was referenced Sep 17, 2018

Set up CI with Azure Pipelines #1729

Closed

Moved test results to TESTS tab in AppVeyor #1725

Closed

jageall and others added 11 commits September 18, 2018 09:41

build: Removed unused Sublime Text project files

e029aa3

build: Use msbuild over xbuild for Mono

13d9056

This commit uses msbuild in preference to xbuild on *nix systems. We also call the restore target prior to the compile target.

Updated dependencies and references for new sdks

0b5474f

- moved Eventstore.Rags under src - dependencies are now pulled from myget feed

rags: Remove AssemblyVersion directive

237c370

build: Add Packer template for Linux build image

16ac350

build: Remove xml doctype

f1a5837

build: Output rags tests to correct location

03c5957

build: Fix solution file

861c493

build: Remove xml tag

c11ace7

build: Consolidate libraries

4b2880c

Switch to mono 5.16:

a058235

- Pin version of mono to be installed to 5.16 on OS X - Pin version of mono to be installed to 5.16 on Centos 7 image Co-authored-by: Avish Cheetaram <avishcheetaram.ai@gmail.com>

shaan1337 force-pushed the new-project-format branch from 06d0b4f to a058235 Compare October 24, 2018 06:17

shaan1337 added 2 commits October 24, 2018 11:05

Use 4.7-api on mono

6c05604

Fix artifact names in ci.yml

a433f9d

shaan1337 force-pushed the new-project-format branch from 74e1ff5 to a433f9d Compare October 24, 2018 07:07

shaan1337 requested a review from riccardone October 24, 2018 08:32

shaan1337 added 10 commits October 24, 2018 13:29

Set dotnet test verbosity to "normal"

264178e

Add timeout of 20 minutes to each job

2327cb0

Ignore flaky test

e5b9ef0

Add workaround for issue #1744 until fixed

ca92759

Add missing break to switch-case, throwing wrong errors when there ar…

0ba7e81

…e timeouts on EmbeddedClient

Increase MiniNode and MiniClusterNode prepare & commit timeouts to 10s

b79130f

Ignore flaky test

3f1255c

Increase projection timeouts to 20s

c4ebdaa

Change test wait time to 8s to exceed QueryManager queryTimeout (8 x …

74f291c

…3 = 24s, queryTimeout = 20s)

shaan1337 force-pushed the new-project-format branch from 584ece5 to 74f291c Compare October 31, 2018 05:15

shaan1337 added 2 commits October 31, 2018 10:23

Remove unused projection libraries for OS X

b4e28d2

Add new build/test instructions and update prerequisites

b4511fa

Add links to projection library build instructions Add instructions to build UI Add Azure Pipelines status badge Remove outdated information

shaan1337 force-pushed the new-project-format branch from 8c5bf92 to b4511fa Compare October 31, 2018 09:43

Add link to docker image hosted on eventstore's docker account

8ec99cc

shaan1337 previously approved these changes Nov 1, 2018

View reviewed changes

Update licenses

b6736f6

shaan1337 dismissed their stale review via b6736f6 November 1, 2018 07:21

shaan1337 approved these changes Nov 1, 2018

View reviewed changes

shaan1337 merged commit be95ac0 into master Nov 1, 2018

jen20 changed the title ~~[WIP] Convert projects to .NET SDK Format~~ Convert projects to .NET SDK Format Nov 2, 2018

jen20 deleted the new-project-format branch November 2, 2018 20:43

shaan1337 mentioned this pull request Nov 12, 2018

Update build.cmd #1765

Merged

shaan1337 mentioned this pull request Dec 10, 2018

Switch from AppVeyor and Wercker to CirrusCI #1718

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert projects to .NET SDK Format #1710

Convert projects to .NET SDK Format #1710

jen20 commented Aug 27, 2018

jen20 commented Aug 27, 2018

enricosada left a comment

enricosada Sep 4, 2018

jen20 Sep 4, 2018

enricosada Sep 4, 2018

jen20 Sep 4, 2018

enricosada Sep 4, 2018

jen20 Sep 4, 2018

enricosada Sep 4, 2018

jen20 Sep 4, 2018 •

edited

jen20 commented Sep 4, 2018

enricosada commented Sep 4, 2018

Convert projects to .NET SDK Format #1710

Convert projects to .NET SDK Format #1710

Conversation

jen20 commented Aug 27, 2018

jen20 commented Aug 27, 2018

enricosada left a comment

Choose a reason for hiding this comment

enricosada Sep 4, 2018

Choose a reason for hiding this comment

jen20 Sep 4, 2018

Choose a reason for hiding this comment

enricosada Sep 4, 2018

Choose a reason for hiding this comment

jen20 Sep 4, 2018

Choose a reason for hiding this comment

enricosada Sep 4, 2018

Choose a reason for hiding this comment

jen20 Sep 4, 2018

Choose a reason for hiding this comment

enricosada Sep 4, 2018

Choose a reason for hiding this comment

jen20 Sep 4, 2018 • edited

Choose a reason for hiding this comment

jen20 commented Sep 4, 2018

enricosada commented Sep 4, 2018

jen20 Sep 4, 2018 •

edited