Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the xml docs for TCP client settings builders #2393

Merged
merged 1 commit into from Mar 31, 2020

Conversation

hayley-jean
Copy link
Member

@hayley-jean hayley-jean commented Mar 26, 2020

Changed: Correct the xml documentation for the TCP Client settings builders.

@hayley-jean hayley-jean added area/documentation Issues relating to project documentation area/cleanup Issues relating to code cleanup labels Mar 26, 2020
@hayley-jean hayley-jean self-assigned this Mar 26, 2020
Copy link
Collaborator

@eventstore-bot eventstore-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request description doesn't meet requirements:

  • No change text detected

@mat-mcloughlin mat-mcloughlin self-requested a review March 26, 2020 11:09
@jageall jageall requested review from jageall and pgermishuys and removed request for mat-mcloughlin March 27, 2020 11:10
@mat-mcloughlin mat-mcloughlin requested review from mat-mcloughlin and removed request for pgermishuys March 30, 2020 10:11
@pgermishuys pgermishuys dismissed eventstore-bot’s stale review March 31, 2020 05:54

Addressed requested change

@pgermishuys pgermishuys merged commit f15c21f into master Mar 31, 2020
@pgermishuys pgermishuys deleted the fix-connection-setting-docs branch March 31, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cleanup Issues relating to code cleanup area/documentation Issues relating to project documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants