Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform Database Check only w/ Both Index and Db Specified #2502

Merged
merged 1 commit into from
May 20, 2020
Merged

Perform Database Check only w/ Both Index and Db Specified #2502

merged 1 commit into from
May 20, 2020

Conversation

thefringeninja
Copy link
Contributor

@thefringeninja thefringeninja commented May 18, 2020 •
edited

Fixed: When starting Event Store without an Index Path specified (as is the case when running in memory), the server would crash with a NullReferenceException.

@thefringeninja thefringeninja self-assigned this May 18, 2020
pgermishuys
pgermishuys previously requested changes May 19, 2020
View reviewed changes
Copy link
Contributor

@pgermishuys pgermishuys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after testing.
Would you mind amending the changelog message to be a little more descriptive in what it fixes?

@pgermishuys pgermishuys dismissed their stale review May 19, 2020 06:59

Other testing taking place.

pgermishuys
pgermishuys suggested changes May 19, 2020
View reviewed changes
Copy link
Contributor

@pgermishuys pgermishuys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after testing.
Would you mind amending the changelog message to be a little more descriptive in what it fixes?

@jageall jageall self-requested a review May 20, 2020 09:04
@jageall jageall merged commit ca67b9a into EventStore:master May 20, 2020
@thefringeninja thefringeninja deleted the fix-paths branch May 29, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgermishuys pgermishuys pgermishuys approved these changes

@jageall jageall jageall approved these changes

@avish0694 avish0694 Awaiting requested review from avish0694

Assignees

@thefringeninja thefringeninja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefringeninja @pgermishuys @jageall