Secure Mode #2628
Merged
Secure Mode #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayley-jean
force-pushed
the
secure-mode
branch
from
3b0b1d5
to
d59c1af
Compare
pgermishuys
approved these changes
Aug 10, 2020
thefringeninja
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: DisableInternalTcpTls has no effect, Insecure mode should be used to disable it
Fixes https://github.com/EventStore/home/issues/226
Relies on #2614
Prevent internal tcp from being disabled when in secure mode.
By default, Event Store will start up with TLS enabled for HTTP, gRPC and TCP.
External TCP TLS can still be disabled to allow legacy TCP clients to connect.