Integrate first V3 record: Epoch #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothycoleman
changed the title
timothycoleman
force-pushed
the
log-v3/record-groundwork
branch
from
f711373
to
669f640
Compare
timothycoleman
force-pushed
the
log-v3/epochs
branch
from
7186897
to
f1ab169
Compare
timothycoleman
force-pushed
the
log-v3/record-groundwork
branch
from
669f640
to
5a39bf2
Compare
timothycoleman
force-pushed
the
log-v3/record-groundwork
branch
from
61bd389
to
5a39bf2
Compare
shaan1337
reviewed
Apr 22, 2021
There was a problem hiding this comment.
@timothycoleman can you please rebase the PR? there are 3 extra commits from the previous PRs. thanks!
shaan1337
reviewed
Apr 22, 2021
shaan1337
reviewed
Apr 22, 2021
|
great, thanks. i'll rebase when the pr that this one depends on has gone into master (cause i'll have to do it then anyway) |
shaan1337
previously approved these changes
Apr 22, 2021
timothycoleman
force-pushed
the
log-v3/record-groundwork
branch
from
5a39bf2
to
f5b0c15
Compare
timothycoleman
force-pushed
the
log-v3/epochs
branch
from
8b11a15
to
667944e
Compare
- This connects up the Epoch record in the v3 project via the record factory abstraction point - V3 Epochs are distinguished from V2 epochs with the version field - V3 is enabled disabled manually in ClusterVNodeHostedService
timothycoleman
force-pushed
the
log-v3/epochs
branch
from
667944e
to
9bba7ea
Compare
|
@shaan1337 ive rebased it now :) |
shaan1337
approved these changes
Apr 26, 2021
YoEight
approved these changes
Apr 26, 2021
pvanbuijtene
pushed a commit
that referenced
this pull request
Apr 29, 2021
- This connects up the Epoch record in the v3 project via the record factory abstraction point - V3 Epochs are distinguished from V2 epochs with the version field - V3 is enabled disabled manually in ClusterVNodeHostedService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: V3 Epoch integration