Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose emitEnabled on create projection request #3384

Merged
merged 1 commit into from Jan 19, 2022
Merged

Expose emitEnabled on create projection request #3384

merged 1 commit into from Jan 19, 2022

Conversation

pvanbuijtene
Copy link
Member

@pvanbuijtene pvanbuijtene commented Jan 17, 2022

Added: Expose emitEnabled on creation of continuous projection.

Closes #2735

@pvanbuijtene pvanbuijtene changed the title Expose emit on projection create request Expose emitEnabled on projection create request Jan 17, 2022
@pvanbuijtene pvanbuijtene changed the title Expose emitEnabled on projection create request Expose emitEnabled on create projection request Jan 17, 2022
thefringeninja
thefringeninja previously approved these changes Jan 17, 2022
_ => false
};
var trackEmittedStreams = (options.ModeCase, emitEnabled) switch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces -> tabs 🤪

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Copy link
Contributor

@timothycoleman timothycoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if relevant, but if im reading it right the previous behaviour set exactly one of emit or track for continuous projections, i.e.

if options.continuous.track then emit but dont track
else track but dont emit

which is different to how its described in the bug

but what we have now looks good, implements the expected behaviour from the ticket

@pvanbuijtene pvanbuijtene added cherry-pick:release/oss-v20.10 Cherry picks PR into v20.10 release branch cherry-pick:release/oss-v21.10 Cherry picks PR into v21.10 release branch labels Jan 19, 2022
@pvanbuijtene pvanbuijtene merged commit 5b10ba3 into EventStore:master Jan 19, 2022
@pvanbuijtene pvanbuijtene deleted the add-emit branch January 19, 2022 13:27
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 @pvanbuijtene Failed to create cherry Pick PR due to error:

RequestError [HttpError]: Merge conflict
   at /home/runner/work/_actions/EventStore/Automations/master/cherry-pick-pr-for-label/node_modules/@octokit/request/dist-node/index.js:66:23
   at processTicksAndRejections (internal/process/task_queues.js:93:5) {
 name: 'HttpError',
 status: 409,
 headers: {
   'access-control-allow-origin': '*',
   'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
   connection: 'close',
   'content-length': '110',
   'content-security-policy': "default-src 'none'",
   'content-type': 'application/json; charset=utf-8',
   date: 'Wed, 19 Jan 2022 13:27:48 GMT',
   'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
   server: 'GitHub.com',
   'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
   vary: 'Accept-Encoding, Accept, X-Requested-With',
   'x-content-type-options': 'nosniff',
   'x-frame-options': 'deny',
   'x-github-media-type': 'github.v3; format=json',
   'x-github-request-id': '07C1:4609:22A3355:616A495:61E811D3',
   'x-ratelimit-limit': '1000',
   'x-ratelimit-remaining': '990',
   'x-ratelimit-reset': '1642602464',
   'x-ratelimit-resource': 'core',
   'x-ratelimit-used': '10',
   'x-xss-protection': '0'
 },
 request: {
   method: 'POST',
   url: 'https://api.github.com/repos/EventStore/EventStore/merges',
   headers: {
     accept: 'application/vnd.github.v3+json',
     'user-agent': 'octokit-core.js/3.3.2 Node.js/12.13.1 (linux; x64)',
     authorization: 'token [REDACTED]',
     'content-type': 'application/json; charset=utf-8'
   },
   body: '{"base":"cherry-pick-cherry-pick/3384/add-emit-release/oss-v20.10-06c532a4-3f4c-4658-8af9-bf224acb3b39","commit_message":"Merge 3e0461e46f4c21acfbffafaa07afcb5682782495 into cherry-pick-cherry-pick/3384/add-emit-release/oss-v20.10-06c532a4-3f4c-4658-8af9-bf224acb3b39 [skip ci]\\n\\n\\nskip-checks: true\\n","head":"3e0461e46f4c21acfbffafaa07afcb5682782495"}',
   request: { agent: [Agent], hook: [Function: bound bound register] }
 },
 documentation_url: 'https://docs.github.com/rest/reference/repos#merge-a-branch'
}

🚨👉 Check https://github.com/EventStore/EventStore/actions/runs/1718217331

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvanbuijtene 👉 Created pull request targeting release/oss-v21.10: #3390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick:release/oss-v20.10 Cherry picks PR into v20.10 release branch cherry-pick:release/oss-v21.10 Cherry picks PR into v21.10 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gRPC] Projections proto does not expose emitEnabled
3 participants