Fix incorrect error message when deleting a stream using gRPC #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
321zer0
changed the title
timothycoleman
previously approved these changes
Sep 8, 2022
321zer0
changed the title
321zer0
changed the title
hayley-jean
reviewed
Sep 12, 2022
hayley-jean
reviewed
Sep 12, 2022
|
just needs squashing to a single commit |
Future usages of WrongExpectedVersion can specify an operation name instead of it being hardcoded.
321zer0
force-pushed
the
fix-incorrect-error-grpc-stream-delete
branch
from
a78e42c
to
a782e69
Compare
timothycoleman
approved these changes
Sep 14, 2022
hayley-jean
approved these changes
Sep 15, 2022
hayley-jean
added a commit
that referenced
this pull request
Nov 21, 2022
…-delete Fix incorrect error message when deleting a stream using gRPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Incorrect error message when deleting a stream using gRPC. Fixes issue #3547