Update log level to Warning if allowUnknownOptions sets to true #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DB-60 Unknown options log level when `AllowUnknownOptions` is enabled
Suggestion by yves.lorphelin Also when using It might be that the customer mistyped an option name, and when invalid options are allowed, it won't do anything, and with |
timothycoleman
approved these changes
May 19, 2023
hayley-jean
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Update log level to Warning if allowUnknownOptions sets to true
Fixes https://linear.app/eventstore/issue/DB-60/unknown-options-log-level-when-allowunknownoptions-is-enabled
The goal of this PR is to update the log level from INF to WRN when allowUnknownOptions sets to true. This will help to detect the cases where user accidentally entered the incorrect option.