[DB-614] Make gossip available as a mem stream: $mem-gossip #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothycoleman
changed the title
|
hm something might not be quite right because the UI keeps requerying immediately |
Works very similarly to the $mem-node-state stream. Factored out a helper class. Both mem streams are in the same logical log because the SubscriptionsService currently supports one physical log and one inmemory log.
timothycoleman
force-pushed
the
timothycoleman/add-gossip-mem-stream
branch
from
36fd072
to
8023d6a
Compare
timothycoleman
changed the title
|
Figured out the problem with help from @Lougarou, the TfLastPosition wasn't correct on the read, causing the longpoll from the UI to be responded to by the server immediately |
timothycoleman
requested review from
hayley-jean
and removed request for
pvanbuijtene
YoEight
approved these changes
Feb 1, 2024
hayley-jean
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: $mem-gossip memory stream
Works very similarly to the $mem-node-state stream. Factored out a helper class.
Plugins will then be able to subscribe to the gossip like other streams without needing a special API