Refactor the build system for Linux and Mac OS X #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the build process for Linux and Mac OS X. It no longer co-mingles the build of libjs1 with the build of Event Store. Instead, when building Event Store, we assume a pre-built version of libjs1.[so|dylib] is available in src/libs/x64/<current distro/version>. The current distro and version is detected using a modified version of a script by Boundary (Apache license, see scripts/build-js1/detect-system.sh). It can also be overriden as the final parameter to the build script. Pre-build versions of libjs1 are included for: - Amazon Linux 2015.03 - Ubuntu Linux 14.04 (LTS) - Mac OS X Yosemite (10.10) Changes are as follows: - Remove support for specifying platform (x64 vs x86) - only x64 is supported for Event Store. - Add libjs1 built for Amazon Linux 2015.03 - Add script for building JS1 on different Linux distros - Add js1 build script for MacOS X - Remove werror flag setting from build.sh - this is now handled by the build scripts for libjs1 only - Remove actions from the build script for Event Store. The only remaining action is "quick" and there is no parameter for this - Rename libs/x64/ubuntu-trusty -> ubuntu-14.04 - Rename libs/x64/mac -> osx-10.10 The README is updated with the latest build instructions, as well as directing to the new documentation path.
jen20
added
kind/enhancement
After we establish the current distribution, we need to check if the libjs1 file instead of the directory exists
pgermishuys
added a commit
that referenced
this pull request
Sep 1, 2015
Refactor the build system for Linux and Mac OS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the build process for Linux and Mac OS X. It no longer co-mingles the build of
libjs1with the build of Event Store. Instead, when building Event Store, we assume a pre-built version oflibjs1.[so|dylib]is available insrc/libs/x64/<current distro/version>.The current distro and version is detected using a modified version of a script by Boundary (Apache license, see
scripts/build-js1/detect-system.sh). It can also be overridden as the final parameter to the build script.Pre-build versions of
libjs1are included for:Changes are as follows:
libjs1built for Amazon Linux 2015.03libjs1on different Linux distroslibjs1build script for MacOS Xwerrorflag setting frombuild.sh- this is now handled by the build scripts forlibjs1onlylibs/x64/ubuntu-trusty->ubuntu-14.04libs/x64/mac->osx-10.10The README is updated with the latest build instructions, as well as directing to the new documentation path.