New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EventStoreCatchUpSubscription Async #837
Make EventStoreCatchUpSubscription Async #837
Conversation
Looks like the Travis build is not working correctly. |
I believe its timing out on tests. @hayleyjean is looking at it. It will take us a bit to review this though it looks reasonable on first Cheers, Greg On Tue, Mar 8, 2016 at 12:55 PM, samhjohnson notifications@github.com
Studying for the Turing test |
Ok my tests failing now will fix up. |
This looks good to me. @samhjohnson mind squashing those commits? |
6709ce1
to
60455a0
Compare
BTW have squashed commits. |
👍 looks reasonable and we will schedule some stress testing on it before release |
Make EventStoreCatchUpSubscription Async
So we will be doing some stress testing on this. I was going through the code today and wondered what will happen if eventappeared (_,x) => Thread.Sleep(5000) In the old version of the code, this was handled here: https://github.com/EventStore/EventStore/blob/oss-v3.5.0/src/EventStore.ClientAPI/EventStoreCatchUpSubscription.cs#L272 all processing by client was specifically dispatched to another thread so a bad client couldn't screw up internal processing of the client. |
Revert of Make EventStoreCatchUpSubscription Async #837
EventStoreCatchUpSubscriptions blocked when calling ReadAllEventsForwardAsync on subscribing with catch up subscriptions. This allows for asynchronous initialization of catch up subscriptions preventing blocking calls and excessive thread usage.
In addition to this it also fixes a bug when disconnects occur where events can be delivered out of order on resubscribe.