Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubscribeToStreamAsync method signature different than documentation states #545

Open
jjwilliams42 opened this issue Aug 1, 2022 · 3 comments

Comments

@jjwilliams42
Copy link

jjwilliams42 commented Aug 1, 2022

New to ESDB. The method signature of SubscribeToStreamAsync on version 22 is different than the documentation states.

The docs says there is a "groupName" field, yet the actual method signature does not have it (in code).

I wrote it up here: https://discuss.eventstore.com/t/subscribetostreamasync-missing-groupname-argument/4316

But noticed most questions in this category on the forum go unanswered, so figured I'd post it here.

I couldn't find any other documentation to show how I might do what I need to do so I'm kind of stuck.

DOC-141

@jjwilliams42
Copy link
Author

Update:

Turns out you just left off which client needs to be instantiated in the persistent subscriptions documentation (and the needed nuget dependency).

For anyone else who pulls their hair out over this, I pulled the source code and found this:

When using gRPC with a persistent subscription - you cannot just use the EventStoreClient. My mistake was going from their gRPC "Getting Started" where they just new up an EventStoreClient to the persistent subscription docs (which doesn't instantiate anything - the examples just show method executions like client.SubscribeToStreamAsync()).

The client discussed in this code:

image

Is actually an EventStorePersistentSubscriptionsClient (maybe - can someone from the ES team confirm?), which, after more digging, is in a completely different nuget dependency: EventStore.Client.Grpc.PersistentSubscriptions (which also isn't mentioned in the documentation)

I'm pretty exhausted TBH, and I feel like an idiot for not seeing this.

Recommendation: improve package reference mentions and show which clients you are instantiating in your docs.

The smoother the onboarding the easier it is for me to make a case to my organization for ES.

@jjwilliams42
Copy link
Author

This is for the persistent subscription documentation at https://developers.eventstore.com/clients/grpc/persistent-subscriptions.html#creating-a-subscription-group

@natrexjacobs
Copy link

natrexjacobs commented Aug 19, 2024

Just noting that as of today the deployed docs still don't appear to mention EventStorePersistentSubscriptionsClient anywhere.

The 'logical' places I looked first:

@alexeyzimarev alexeyzimarev reopened this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants