add ability to upgrade server to higher server version #96
Conversation
| @@ -272,6 +287,28 @@ func resourceManagedClusterUpdate(ctx context.Context, d *schema.ResourceData, m | |||
| } | |||
| } | |||
|
|
|||
| serverVersionTag, serverVersionTagFound := d.GetOk("server_version_tag") | |||
|
|
|||
| if serverVersionTagFound && d.HasChange("server_version_tag") { | |||
There was a problem hiding this comment.
This condition should check also if server_version has changed. In either case it should be OK to do the upgrade.
There was a problem hiding this comment.
One more check: here and elsewhere the provider needs to issue an error if the server_version is not a prefix of server_version_tag.
| @@ -233,6 +245,9 @@ func resourceManagedClusterRead(ctx context.Context, d *schema.ResourceData, met | |||
| if err := d.Set("server_version", resp.ManagedCluster.ServerVersion); err != nil { | |||
| diags = append(diags, diag.FromErr(err)...) | |||
| } | |||
| if err := d.Set("server_version_tag", resp.ManagedCluster.ServerVersionTag); err != nil { | |||
There was a problem hiding this comment.
It's ok to validate these when creating a new resource, but as-is it will validate existing clusters that have server version tags that were valid. I think we should just avoid validation on this and trust the server to do it. We can and should improve the server error messages to make this clearer.
esc/resource_managed_cluster.go
Outdated
| serverVersion := d.Get("server_version").(string) | ||
|
|
||
| if !strings.HasPrefix(serverVersionTag.(string), serverVersion) { | ||
| return diag.FromErr(errors.New("invalid server_version given")) |
There was a problem hiding this comment.
Make this:
return diag.FromErr(fmt.Errorf("invalid server_version_tag: tag \"%s\" must begin with version \"%\"", serverVersionTag.(string), serverVersion))
esc/provider.go
Outdated
| @@ -154,7 +154,7 @@ var slowResourceTimeout = &schema.ResourceTimeout{ | |||
| } | |||
|
|
|||
| var validProviders = []string{"aws", "gcp", "azure"} | |||
| var validServerVersions = []string{"20.6", "20.10", "21.6", "21.10", "22.6", "22.10", "23.6", "23.10"} | |||
| var validServerVersions = []string{"21.10", "22.6", "22.10", "23.6", "23.10"} | |||
There was a problem hiding this comment.
Keep "20.6", "20.10", "21.6", in or we'll prevent people who have older versions from using terraform.
closes CLO-803