Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix walrus usage for 3.7 compatibility #488

Closed
jaychia opened this issue Jan 20, 2023 · 0 comments · Fixed by #489
Closed

Fix walrus usage for 3.7 compatibility #488

jaychia opened this issue Jan 20, 2023 · 0 comments · Fixed by #489
Assignees
@jaychia
Labels
bug Something isn't working

Comments

@jaychia
Copy link
Contributor

jaychia commented Jan 20, 2023

Describe the bug

The walrus (:=) operator is only available in Python >= 3.8

We use it in a few places, and should fix it for 3.7 compatibility
@jaychia jaychia added the bug Something isn't working label Jan 20, 2023
@jaychia jaychia assigned xcharleslin and jaychia and unassigned xcharleslin Jan 20, 2023
@jaychia jaychia linked a pull request Jan 20, 2023 that will close this issue
Remove walrus operators for Py 3.7 compatibility #489
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaychia jaychia

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove walrus operators for Py 3.7 compatibility Eventual-Inc/Daft
2 participants
@xcharleslin @jaychia