Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable threading in PyRunner #613

Closed
xcharleslin opened this issue Feb 22, 2023 · 0 comments · Fixed by #614
Closed

Add option to disable threading in PyRunner #613

xcharleslin opened this issue Feb 22, 2023 · 0 comments · Fixed by #614
Assignees
@xcharleslin

Comments

@xcharleslin
Copy link
Contributor

Third party libraries or user code may break when ran in python multithreading, so we should expose the option to disable it.
@xcharleslin xcharleslin self-assigned this Feb 22, 2023
@xcharleslin xcharleslin mentioned this issue Feb 22, 2023
Merged
@xcharleslin xcharleslin linked a pull request Feb 22, 2023 that will close this issue
Add option to disable threadpool in PyRunner #614
Merged
xcharleslin added a commit that referenced this issue Feb 22, 2023
@xcharleslin
Add option to disable threadpool in PyRunner (#614)
f9c9ce6 
Closes:
- #613

CLI: `DAFT_DEVELOPER_USE_THREAD_POOL=0`
Python: 
```python
set_runner_py(use_thread_pool=False)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcharleslin xcharleslin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to disable threadpool in PyRunner Eventual-Inc/Daft
1 participant
@xcharleslin