Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Basic support for Arrow 128-bit Decimal. #1129

Merged
merged 18 commits into from
Jul 13, 2023
Merged

Conversation

xcharleslin
Copy link
Contributor

@xcharleslin xcharleslin commented Jul 7, 2023

Arrow roundtrip, Python roundtrip, Parquet roundtrip.

Uses a new Int128Type under the hood.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1129 (28e51b5) into main (02d31f8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   88.40%   88.39%   -0.02%     
==========================================
  Files          54       54              
  Lines        5478     5488      +10     
==========================================
+ Hits         4843     4851       +8     
- Misses        635      637       +2     
Impacted Files Coverage Δ
daft/datatype.py 92.72% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

@xcharleslin xcharleslin changed the title Charles/decimal [FEAT] Basic support for Arrow 128-bit Decimal. Jul 12, 2023
@github-actions github-actions bot added the enhancement New feature or request label Jul 12, 2023
@xcharleslin xcharleslin marked this pull request as ready for review July 13, 2023 20:56
@xcharleslin xcharleslin enabled auto-merge (squash) July 13, 2023 20:56
@xcharleslin xcharleslin merged commit 03a6646 into main Jul 13, 2023
22 checks passed
@xcharleslin xcharleslin deleted the charles/decimal branch July 13, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant