[FEAT] parquet reader refactor, add parquet_stats_reader and parquet_schema_reader (1/2) #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samster25
changed the title
samster25
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
- Coverage 88.44% 88.37% -0.07%
==========================================
Files 54 54
Lines 5564 5576 +12
==========================================
+ Hits 4921 4928 +7
- Misses 643 648 +5
|
jaychia
approved these changes
Jul 26, 2023
| max_request_size: 16 * 1024 * 1024, | ||
| split_threshold: 24 * 1024 * 1024, | ||
| })); | ||
| pub fn read_parquet_statistics(uris: &Series, io_client: Arc<IOClient>) -> DaftResult<Table> { |
There was a problem hiding this comment.
It's not a requirement for us to get the result of this operation as a Table (a Vec<ParquetFileStatstics> or Vec<(int, int, str)> could suffice) but if this avoids more Python glue code then should be fine
| io_client, | ||
| )? | ||
| .into()) | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
Python-facing functions look good, should work!
| row_groups: list[int] | None = None, | ||
| file_size: None | int = None, | ||
| start_offset: int | None = None, | ||
| num_rows: int | None = None, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table.read_parquet_statisticsto grab basic stats from a series of urlsSchema.from_parquetto generate Schema from parquet file