Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [New Query Planner] Add support for `df.count_rows(). #1273

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

clarkzinzow
Copy link
Contributor

This PR adds support for df.count_rows(), the final missing implementation from the LogicalPlanBuilder interface for the new query planner.

@github-actions github-actions bot added the enhancement New feature or request label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1273 (0039978) into main (a5c702b) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
- Coverage   87.75%   87.73%   -0.03%     
==========================================
  Files          61       61              
  Lines        6021     6023       +2     
==========================================
  Hits         5284     5284              
- Misses        737      739       +2     
Files Changed Coverage Δ
daft/logical/rust_logical_plan.py 87.89% <25.00%> (-1.14%) ⬇️
daft/expressions/expressions.py 91.83% <100.00%> (ø)
daft/series.py 92.09% <100.00%> (ø)

@clarkzinzow clarkzinzow merged commit 57853db into main Aug 15, 2023
17 of 18 checks passed
@clarkzinzow clarkzinzow deleted the clark/count branch August 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant