[FEAT] 1606 - Adding hour expression in date util #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
+ Coverage 84.88% 85.02% +0.13%
==========================================
Files 55 55
Lines 5287 5314 +27
==========================================
+ Hits 4488 4518 +30
+ Misses 799 796 -3
|
suriya-ganesh
changed the title
samster25
changed the title
samster25
reviewed
Nov 21, 2023
src/daft-core/src/array/ops/date.rs
Outdated
| std::sync::Arc::new(Field::new(self.name(), DataType::UInt32)), | ||
| Box::new(date_arrow), | ||
| ) | ||
| .unwrap_or(UInt32Array::from(("hour", vec![0])))) |
There was a problem hiding this comment.
You shouldn't have to unwrap the UInt32Array::new and then wrap it in Ok. You should be able to return the result from UInt32Array::new directly!
UInt32Array::new(
std::sync::Arc::new(Field::new(self.name(), DataType::UInt32)),
Box::new(date_arrow),
)
There was a problem hiding this comment.
Yea, not sure what I was thinking. Fixing it now.
|
looks great! |
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
dt_hour()Expression to fetch hour of the current day in a column. Based on, #1606