[FEAT] Add find functionality for string #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murex971
force-pushed
the
murex/str-find
branch
from
861f6ed
to
f1f1e30
Compare
jaychia
reviewed
Mar 30, 2024
murex971
commented
Mar 31, 2024
murex971
force-pushed
the
murex/str-find
branch
from
6275ae0
to
d50d161
Compare
jaychia
approved these changes
Apr 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2046 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 62 62
Lines 6840 6849 +9
=======================================
+ Hits 5795 5803 +8
- Misses 1045 1046 +1
|
|
Great work! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1925
Returns the first occurrence of the
substrprovided,-1, in case of fails to find.