[CHORE] FunctionEvaluator directly receive FunctionExpr
#2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeepoWin
commented
Apr 14, 2024
| @@ -190,9 +190,7 @@ impl AggExpr { | |||
| ))), | |||
| } | |||
| } | |||
| MapGroups { func, inputs } => { | |||
| func.to_field(inputs.as_slice(), schema, &Expr::Agg(self.clone())) | |||
There was a problem hiding this comment.
The Expr::Agg here is actually useless: MapGroups only allow UDFs, and PythonUDF doesn't use the Expr passed in indeed.
If we really want the FunctionEvaluator to know if we're in an aggregation, an additional Context(Default/Agg) argument would make more sense I think.
There was a problem hiding this comment.
Ah you're right! @colin-ho Was the rationale behind recreating the expression?
samster25
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sort of annoying to have to write the useless
Expr::Functionevery time.