Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Map Getter #2255

Merged
merged 3 commits into from
May 14, 2024
Merged

[FEAT] Map Getter #2255

merged 3 commits into from
May 14, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented May 8, 2024

Closes #2240

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 65.85366% with 42 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@7ef1c4b). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2255   +/-   ##
=======================================
  Coverage        ?   79.21%           
=======================================
  Files           ?      463           
  Lines           ?    53243           
  Branches        ?        0           
=======================================
  Hits            ?    42175           
  Misses          ?    11068           
  Partials        ?        0           
Files Coverage Δ
daft/expressions/expressions.py 93.21% <100.00%> (ø)
src/daft-core/src/series/ops/downcast.rs 84.44% <100.00%> (ø)
src/daft-core/src/series/ops/mod.rs 100.00% <ø> (ø)
src/daft-dsl/src/functions/mod.rs 100.00% <100.00%> (ø)
src/daft-dsl/src/python.rs 93.24% <100.00%> (ø)
src/daft-dsl/src/functions/map/mod.rs 92.85% <92.85%> (ø)
daft/series.py 92.21% <66.66%> (ø)
src/daft-core/src/python/series.rs 94.75% <0.00%> (ø)
src/daft-core/src/series/ops/map.rs 50.00% <50.00%> (ø)
src/daft-core/src/array/ops/map.rs 72.72% <72.72%> (ø)
... and 1 more

@samster25
Copy link
Member

👀

@samster25 samster25 merged commit 4e2c954 into main May 14, 2024
44 checks passed
@samster25 samster25 deleted the colin/map_get branch May 14, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a map_get expression to enable users to efficiently work with Map DataTypes
2 participants