Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Improve docs for external types #2274

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

kevinzwang
Copy link
Member

Made docs more clear about the types of non-Daft classes, also includes links to relevant external docs when relevant

@kevinzwang kevinzwang requested a review from jaychia May 13, 2024 20:41
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 13, 2024
def to_pandas(self, cast_tensors_to_ray_tensor_dtype: bool = False) -> "pd.DataFrame":
"""Converts the current DataFrame to a pandas DataFrame.
def to_pandas(self, cast_tensors_to_ray_tensor_dtype: bool = False) -> "pandas.DataFrame":
"""Converts the current DataFrame to a `pandas DataFrame <https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.html>`__.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think links are single underscore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinzwang kevinzwang merged commit 9d4865a into main May 13, 2024
42 checks passed
@kevinzwang kevinzwang deleted the kevin/docs-external-types branch May 13, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants