Add analytics module for telemetry #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaychia
commented
Dec 31, 2022
Cargo.toml
Outdated
| @@ -19,5 +19,5 @@ git-fetch-with-cli = true | |||
|
|
|||
| [package] | |||
| name = "daft" | |||
| version = "0.0.20" | |||
| version = "0.0.0" | |||
There was a problem hiding this comment.
It seems this is always patched before we build and publish a new Daft release - @samster25 is this a safe way of determining whether this is a Daft release build vs a local/dev build? This PR currently uses Daft version 0.0.0 as a corner-case to disable analytics.
There was a problem hiding this comment.
I wouldn't go about it that way, it would be better to build a flag for a release build rather than relying on the version number.
jaychia
force-pushed
the
jay/telemetry
branch
2 times, most recently
from
0cc9231
to
805612c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAFT_ANALYTICS_ENABLED=0DAFT_PKG_BUILD_TYPE={dev|debug|nightly|release}