Add profiling to benchmarks/tpch. Improve profiler to prevent VizTracer nesting. #423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add daft.runners.profiler to benchmarks.tpch. Now, you can run benchmark with DAFT_PROFILING=1 to generate a profile per question.
The profile will be in the form
tpch_q{num}_{timestamp}.json
.Adding the profiler to TPCH introduces nested profiling, since there are already profiler calls lower in the Daft code. However, VizTracer does not seem to be nestable. It will complain loudly:
and then sometimes segfault:
To work around this, I made Daft's viztracer wrapper its own context manager that no-ops if an existing VizTracer is already active.