Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #299 to work without relying on expression IDs #510

Merged
merged 2 commits into from Jan 26, 2023
Merged

Fixes #299 to work without relying on expression IDs #510

merged 2 commits into from Jan 26, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jan 26, 2023 •
edited

  • Sorts on non-column expression #299 fixes sorts by avoiding recomputations on Expressions that have IDs that already exist in the current vPartition
  • However, moving forward Expressions will be ID-less
  • This PR fixes sorts in a different way, no-opping expression evaluation in quantile_reduce_func during sort sampling

@jaychia jaychia enabled auto-merge (squash) January 26, 2023 01:39
@jaychia jaychia merged commit 1ec273f into main Jan 26, 2023
@jaychia jaychia deleted the jay/fix-299 branch January 26, 2023 01:45
@jaychia jaychia mentioned this pull request Jan 26, 2023
Merged
jaychia added a commit that referenced this pull request Jan 26, 2023
@jaychia
Fix dynamic runners sorting (#512)
afb933d 
* Fixes #510 for dynamic runners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jaychia