Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Expression input_mapping query optimization bug #536

Merged
merged 1 commit into from Feb 1, 2023
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Feb 1, 2023

Closes #534

@jaychia jaychia added the bug Something isn't working label Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #536 (920d673) into main (3c99fbb) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   72.92%   72.91%   -0.02%     
==========================================
  Files          95       95              
  Lines        7638     7638              
==========================================
- Hits         5570     5569       -1     
- Misses       2068     2069       +1     
Impacted Files Coverage Δ
daft/expressions.py 92.74% <100.00%> (-0.59%) ⬇️
daft/logical/optimizer.py 96.86% <0.00%> (+0.89%) ⬆️

@jaychia jaychia merged commit a00b2e3 into main Feb 1, 2023
@jaychia jaychia deleted the jay/fix-mnist branch February 1, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNIST tutorial broken
1 participant