Add Rust bindings for Schema #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 84.18% 84.36% +0.17%
==========================================
Files 113 115 +2
Lines 10403 10526 +123
==========================================
+ Hits 8758 8880 +122
- Misses 1645 1646 +1
|
samster25
reviewed
Mar 3, 2023
daft/logical/schema2.py
Outdated
|
|
||
| def __iter__(self) -> Iterator[Field]: | ||
| col_names = self.column_names() | ||
| return (self[name] for name in col_names) |
There was a problem hiding this comment.
This actually returns a generator rather than a tuple:
>>> x = (i for i in range(10))
>>> type(x)
<class 'generator'>
I can do yield from instead if its clearer?
| s._schema = schema | ||
| return s | ||
|
|
||
| def __getitem__(self, key: str) -> Field: |
There was a problem hiding this comment.
runtime check that key is a str to avoid panic in pyo3
| Ok(self.schema.names()?) | ||
| } | ||
|
|
||
| pub fn union(&self, other: &PySchema) -> PyResult<PySchema> { |
There was a problem hiding this comment.
this union method should be implemented in Schema rather than having the logic in the pybindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
schema2.pywhich includes Rust bindings for schema