Refactor Schema initialization in the codebase #655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema()
is currently initialized withFields
in its__init__
. However, inschema2.py
this will no longer be allowed since the new schemas are Rust datastructures.This refactor changes all locations where we do this intialization to a call to
Schema._from_field_name_and_types
instead, which takes in a simple Python list of tuples, so that integration will be easier.