Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Schema initialization in the codebase #655

Merged
merged 2 commits into from Mar 3, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Mar 3, 2023

Schema() is currently initialized with Fields in its __init__. However, in schema2.py this will no longer be allowed since the new schemas are Rust datastructures.

This refactor changes all locations where we do this intialization to a call to Schema._from_field_name_and_types instead, which takes in a simple Python list of tuples, so that integration will be easier.

@jaychia jaychia enabled auto-merge (squash) March 3, 2023 23:37
@jaychia jaychia merged commit 26ab1a3 into main Mar 3, 2023
@jaychia jaychia deleted the jay/schema-initialization branch March 3, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant