Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement grouped aggregations. #704

Merged
merged 11 commits into from Mar 21, 2023
Merged

Implement grouped aggregations. #704

merged 11 commits into from Mar 21, 2023

Conversation

xcharleslin
Copy link
Contributor

@xcharleslin xcharleslin commented Mar 16, 2023

  • Fills out implementation of agg_groupby for Table in Rust. (The glue layers to the Python API are already done.)
  • Adds a sort_grouper function for Table, which produces an argsort of the table, with identical values grouped together.
  • Uses this to implement a grouped aggregation, which will go through each group, take on the indices, and then eval the aggregation expressions.
  • Tests included. Tested multicolumn, multitype, empty grouped aggregations.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #704 (e35d185) into main (a31099d) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   86.02%   86.18%   +0.15%     
==========================================
  Files         154      154              
  Lines       12589    12668      +79     
==========================================
+ Hits        10830    10918      +88     
+ Misses       1759     1750       -9     
Impacted Files Coverage Δ
src/array/ops/sort.rs 99.30% <100.00%> (+<0.01%) ⬆️
src/table/ops/agg.rs 100.00% <100.00%> (+21.05%) ⬆️

... and 5 files with indirect coverage changes

@xcharleslin xcharleslin changed the title wip groupbys Implement grouped aggregations. Mar 18, 2023
@xcharleslin xcharleslin marked this pull request as ready for review March 18, 2023 00:25
@xcharleslin xcharleslin merged commit 6cea757 into main Mar 21, 2023
8 checks passed
@xcharleslin xcharleslin deleted the charles/rs-groupby branch March 21, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant