Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size_bytes for logical types #724

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Fix size_bytes for logical types #724

merged 2 commits into from
Mar 20, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Mar 20, 2023

  • .size_bytes currently panics if run on logical types (e.g. dates)
  • This PR fixes that behavior by first casting into a Physical type

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #724 (27e73fc) into main (c29f86b) will decrease coverage by 0.07%.
The diff coverage is 88.88%.

❗ Current head 27e73fc differs from pull request most recent head f6ba043. Consider uploading reports for the commit f6ba043 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   86.03%   85.97%   -0.07%     
==========================================
  Files         154      156       +2     
  Lines       12621    12735     +114     
==========================================
+ Hits        10859    10949      +90     
- Misses       1762     1786      +24     
Impacted Files Coverage Δ
src/series/ops/len.rs 85.71% <66.66%> (+2.38%) ⬆️
src/python/series.rs 94.73% <100.00%> (+0.21%) ⬆️
src/python/table.rs 89.30% <100.00%> (ø)
src/table/mod.rs 78.98% <100.00%> (+0.13%) ⬆️

... and 8 files with indirect coverage changes

@jaychia jaychia merged commit e7df931 into main Mar 20, 2023
@jaychia jaychia deleted the jay/size-bytes-logical branch March 20, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant