Initial github setup #1
Conversation
jlordiales
commented
Nov 10, 2023
jlordiales
commented
- Added initial markdown files
- Added protobuf spec and generated Go types
There was a problem hiding this comment.
Given this is a third party, do we need to commit this to our own project?
I'm wondering if we could treat this as a library dependency instead
There was a problem hiding this comment.
I'm not aware of a way to include proto files as a library dependency
There was a problem hiding this comment.
I had more the idea of doing what we do with the schemas in general. Having a dedicated place to just compile to different languages, in our case, go, and we import that library
There was a problem hiding this comment.
So we separate the host library from the underlying proto generation
There was a problem hiding this comment.
that feels like a lot of overhead considering the spec here is stable and won't change
There was a problem hiding this comment.
I'm mostly concerned of having code that belongs to a different org embedded here.
It's not about design, it's more about correctness of licences.
Are you better informed on the legalities here?
There was a problem hiding this comment.
https://chat.openai.com/share/c11ac26a-7686-42ce-b579-428c651fdbd2
I think we should be fine
| // * Copyright (c) 2015, 2018 Cirrus Link Solutions and others | ||
| // * | ||
| // * This program and the accompanying materials are made available under the | ||
| // * terms of the Eclipse Public License 2.0 which is available at |
There was a problem hiding this comment.
I don't know how this works. Can you commit to our Apache licensed software a different one?
