Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces \n to avoid bad HTTP header #13

Merged
merged 1 commit into from
Sep 24, 2016

Conversation

pztrick
Copy link
Contributor

@pztrick pztrick commented Feb 25, 2016

Certain environments may produce a multi-line sys.version which breaks the custom User-Agent header.

E.g. sys.version as Python / 3.5.0 (default, Oct 24 2015, 09:48:42) \n[GCC 4.9.2]

This results in an illegal HTTP header of...

User-Agent: evernote_user:V=2 1.25; Python / 3.5.0 (default, Oct 24 2015, 09:48:42)
[GCC 4.9.2]

This p/r replaces the '\n' character with '' to ensure a valid, one-line HTTP header. E.g.:

User-Agent: evernote_user:V=2 1.25; Python / 3.5.0 (default, Oct 24 2015, 09:48:42) [GCC 4.9.2]

See Evernote/evernote-sdk-python#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants