Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing additional helper methods for the evernote SDK #15

Open
captn3m0 opened this issue Jul 12, 2014 · 5 comments
Open

Contributing additional helper methods for the evernote SDK #15

captn3m0 opened this issue Jul 12, 2014 · 5 comments

Comments

@captn3m0
Copy link

As part of an app I'm working on, I extended the Evernote::EDAM::NoteStore::NoteStore::Client class to add a few helper methods. The method signatures are as follows:

  • find_notebook(name) - Find a notebook with given name
  • create_notebook(name) - Create a notebook with given name, which calls Evernote::EDAM::Type::Notebook.new() for you
  • find_or_create_notebook(name) - Search for a notebook by name, and return either that or create a new notebook and return that.

Currently the code is abstracted in an EvernoteUtil class of mine, but I'd be willing to try to patch it back to the sdk. However, I'd like to know if this repo even accepts contributions and if such contributions (adding helper methods not in official API) might be accepted.

@nozpheratu
Copy link

I appreciate all the work that went into this project, but the public API is a little rough around the edges. @sethhitch you guys accepting public contributions at all?

@captn3m0
Copy link
Author

@nozpheratu I'd say you should take a look at other evernote API wrappers instead.

@nozpheratu
Copy link

@captn3m0 I saw the evernote_util project, but I think there should be one go-to gem that everyone uses. Having wrappers on-top of wrappers just needlessly complicates things IMO.

@captn3m0
Copy link
Author

Yes. I agree. I wish I was conversant with Thrift. The issue is that since its a thrift-based API, its cumbersome to right a gem that does not use Thrift (which screws everything up).

I even wrote a rant on the Evernote API.

@nozpheratu
Copy link

@captn3m0 FWIW, I don't think anybody is conversant with thrift. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants