-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private fields and no getters for table.Column #157
Comments
Everything is unexported to avoid any modifications that would break the flow of Bubble Tea; everything must be immutable. I'm not against adding a read-only getter for Column.key in particular, if that would be useful to you. More out of curiosity than any need for justification, but why did you want to access the key after creating this? I think the usual use case is a set of constant keys, so there doesn't seem to be much need to get the key back out. |
Sorry, I am not the best at writing self-describing titles :D I cannot make constants with column keys because I am not aware of them during build time. I am fetching data from the external API and creating a table on the fly. Currently, I did a workaround with storing columnsKeys as a separate field in my struct but it would be desirable to get them directly from the table. Okay, I will prepare a PR soon then |
Got it... sounds good then, should be pretty straightforward! I'll keep an eye out for PR. |
Released as v0.15.5 |
Is there any specific reason why all fields are private/don't have getters? I would need to have access to the 'key' property and do not know if I should prepare a PR :)
The text was updated successfully, but these errors were encountered: