Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filtered rendering performance #145

Merged
merged 3 commits into from
Mar 18, 2023
Merged

Improve filtered rendering performance #145

merged 3 commits into from
Mar 18, 2023

Conversation

Evertras
Copy link
Owner

@Evertras Evertras commented Mar 18, 2023

GetVisibleRows is being called all over the place. This function is doing a LOT of calculation for any large data set. So instead we cache it, and internally invalidate the cache whenever it would change. This is purely an internal change and seems to massively improve performance when tested.

Helps #135

@Evertras Evertras merged commit 525e143 into main Mar 18, 2023
@Evertras Evertras deleted the filter-benchmarks branch March 18, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant