Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] whole repository file gen #23

Open
Toxicable opened this issue Feb 3, 2020 · 2 comments
Open

[feat] whole repository file gen #23

Toxicable opened this issue Feb 3, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Toxicable
Copy link
Contributor

As seen here: #17 (comment)
I wrote a small script which will serially spawn bzlgen to write build files for our whole repository.
I think it would be worth while feature to upstream this functionality.

To speed this up we could also implement concurrent file generation, to do this we'd simply need to adjust commands.txt so it gets a unique name per instance.

This could also be extended later to include other feattures like watch mode and running as a daemon process.
But for the first instance being able to run over multiple first would make inital migrations to use this easier.

@Toxicable Toxicable changed the title [feat] whole repositry file gen [feat] whole repository file gen Feb 3, 2020
@mattem
Copy link
Contributor

mattem commented Feb 12, 2020

buildozer is very efficient with processing the commands, we probably want to just create one commands file still (a few 1000 buildozer commands take < ~3s to run in my experience).

I'm wondering what level of granularity to generate? (treat all folders with no subfolders as the final generation target?).

I like the notion of watch mode 👍

@Toxicable
Copy link
Contributor Author

Ah right! if we could generate a commands.txt which could do the whole repository at once im sure that would do the trick. I'm not familar with buildozer so not familar with what it has avilable.

For granularity I think we generate a build file per directory that has source files.
I think to be flexible we'd want to provide an api where users can give their own list of dirs. Maybe this is a throug a glob, for examples we'd want to generate files in apps/* and libs/*

We're definately keen on a watch mode also, it would be pretty bad DX running your process with ibazel but having to manually run build file generation on each save also

@mattem mattem added the enhancement New feature or request label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants