Dev.logs

[roedoejet]

Refactored default save_directory for logs and model checkpoints to logs_and_checkpoints instead of logs. Fixes #39

[codecov]

Codecov Report

Merging #75 (5db4ec3) into main (9d6fa75) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   52.92%   52.96%   +0.03%     
==========================================
  Files          43       43              
  Lines        2564     2566       +2     
  Branches      350      350              
==========================================
+ Hits         1357     1359       +2     
  Misses       1138     1138              
  Partials       69       69              

Files Changed	Coverage Δ
everyvoice/config/shared_types.py	84.48% <100.00%> (ø)
everyvoice/tests/test_wizard.py	94.00% <100.00%> (+0.12%)	⬆️
everyvoice/wizard/basic.py	74.40% <100.00%> (+0.20%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[joanise]

I'll let @SamuelLarkin or @marctessier review this, I have no opinion on this one.

[SamuelLarkin]

Humm can the branch be rebased because the diff is showing none related changes?

[joanise]

@SamuelLarkin I'll rebase it shortly.

[joanise]

@SamuelLarkin Rebased, this should be easy to review now.

[SamuelLarkin]

Shouldn't we drop logs if we renamed it to logs_and_checkpoints?

[SamuelLarkin]

Looks sound.

[roedoejet]

Thanks @SamuelLarkin ! For small PRs like this, please rebase instead of creating a merge commit. Thanks!

[roedoejet]

Thanks @SamuelLarkin ! For small PRs like this, please rebase instead of creating a merge commit. Thanks!

Nevermind! I see that you did that! For some reason the app makes it look like you did a merge commit, but I see on the desktop that you rebased. Sorry for the noise!

[joanise]

Well, rebasing this one means we have to rebase all the ones after. I might have taken the time to do a fast-forward merge from the CLI for this one, for that reason, but this is fine too.