Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds styleguide markdown file #18

Merged
merged 2 commits into from May 4, 2021
Merged

adds styleguide markdown file #18

merged 2 commits into from May 4, 2021

Conversation

LDNCWRB
Copy link
Collaborator

@LDNCWRB LDNCWRB commented May 4, 2021

What changes have you made?

  • adds styleguide mardown file - empty for now

Which issue(s) does this PR fix?

Fixes #3

Screenshots (if there are design changes)

How to test

@Jbarget
Copy link
Collaborator

Jbarget commented May 4, 2021

can we add one thing to the styleguide that over the years i've found to be a good way of writing react components:

React component structure

// imports
import blah from "blah-blah"

// types
interface ButtonProps {
  onClick: () => void;
  label: string
}

// component
const Button - (label) => {
  return ( 
    ...button component...
  )
}

// export default
export default Button

@LDNCWRB LDNCWRB merged commit 48199d3 into main May 4, 2021
@LDNCWRB LDNCWRB deleted the styleguide branch May 4, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create styleguide.md
2 participants