Specify statement timeout on Database and SqlQuery #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komu
reviewed
Feb 15, 2020
There was a problem hiding this comment.
Hi, thanks for the PR!
Perhaps the timeout could be represented as java.time.Duration and converted to milliseconds only at at the last moment. It would make things clearer for the callers I guess. You could say db.setDefaultTimeout(Duration.ofSeconds(5)) and so on.
Also, in Database the getter is named getDefaultTimeout but the setter is setTimeout. I guess the name of the setter is a simple mistake?
…ava.time.Duration
|
yep, "setTimeout" is obviously a copy/paste mistake. |
|
I just released |
globalbus
added a commit
to globalbus/dalesbred
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.