Add Contributors List in about page #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add hacktoberfest links and github links to about page - all external links open with new tab instead of same page
We don't need GitHub API. You can use native JavaScript to read the JSON file and present the data from it. |
|
As @NitinNair89 mentioned, I have already created a JSON file and I'm reading it from JS and printing the data. Maybe @SARAN-thala can build on top of that? |
|
Yeah, I read data from the local JSON file only |
|
This is how it looks |
|
It closed #97 aswell |
NitinNair89
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the contributors list stored in JSON file. we can’t get directly from github api they rate limit of 60req/hour.
This is will solve issue #128