implemented #100 : Warn if exporting a non-watertight mesh

Evil-Spirit · Nov 14, 2016 · 05d3a7b · 05d3a7b
1 parent a3f9a4e
commit 05d3a7b
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 29 deletions.
diff --git a/src/export.cpp b/src/export.cpp
@@ -812,7 +812,7 @@ void SolveSpaceUI::ExportMeshTo(const std::string &filename) {
         Error("Couldn't write to '%s'", filename.c_str());
         return;
     }
-
+    ShowNakedEdges(/*reportOnlyWhenNotOkay=*/true);
     if(FilenameHasExtension(filename, ".stl")) {
         ExportMeshAsStlTo(f, m);
     } else if(FilenameHasExtension(filename, ".obj")) {

diff --git a/src/solvespace.cpp b/src/solvespace.cpp
@@ -605,34 +605,7 @@ void SolveSpaceUI::MenuAnalyze(Command id) {
             break;
 
         case Command::NAKED_EDGES: {
-            SS.nakedEdges.Clear();
-
-            Group *g = SK.GetGroup(SS.GW.activeGroup);
-            SMesh *m = &(g->displayMesh);
-            SKdNode *root = SKdNode::From(m);
-            bool inters, leaks;
-            root->MakeCertainEdgesInto(&(SS.nakedEdges),
-                EdgeKind::NAKED_OR_SELF_INTER, /*coplanarIsInter=*/true, &inters, &leaks);
-
-            InvalidateGraphics();
-
-            const char *intersMsg = inters ?
-                "The mesh is self-intersecting (NOT okay, invalid)." :
-                "The mesh is not self-intersecting (okay, valid).";
-            const char *leaksMsg = leaks ?
-                "The mesh has naked edges (NOT okay, invalid)." :
-                "The mesh is watertight (okay, valid).";
-
-            std::string cntMsg = ssprintf("\n\nThe model contains %d triangles, from "
-                            "%d surfaces.", g->displayMesh.l.n, g->runningShell.surface.n);
-
-            if(SS.nakedEdges.l.n == 0) {
-                Message("%s\n\n%s\n\nZero problematic edges, good.%s",
-                    intersMsg, leaksMsg, cntMsg.c_str());
-            } else {
-                Error("%s\n\n%s\n\n%d problematic edges, bad.%s",
-                    intersMsg, leaksMsg, SS.nakedEdges.l.n, cntMsg.c_str());
-            }
+            ShowNakedEdges(/*reportOnlyWhenNotOkay=*/false);
             break;
         }
 
@@ -820,6 +793,40 @@ void SolveSpaceUI::MenuAnalyze(Command id) {
     }
 }
 
+void SolveSpaceUI::ShowNakedEdges(bool reportOnlyWhenNotOkay) {
+    SS.nakedEdges.Clear();
+
+    Group *g = SK.GetGroup(SS.GW.activeGroup);
+    SMesh *m = &(g->displayMesh);
+    SKdNode *root = SKdNode::From(m);
+    bool inters, leaks;
+    root->MakeCertainEdgesInto(&(SS.nakedEdges),
+        EdgeKind::NAKED_OR_SELF_INTER, /*coplanarIsInter=*/true, &inters, &leaks);
+
+    if(reportOnlyWhenNotOkay && !inters && !leaks && SS.nakedEdges.l.n == 0) {
+        return;
+    }
+    InvalidateGraphics();
+
+    const char *intersMsg = inters ?
+        "The mesh is self-intersecting (NOT okay, invalid)." :
+        "The mesh is not self-intersecting (okay, valid).";
+    const char *leaksMsg = leaks ?
+        "The mesh has naked edges (NOT okay, invalid)." :
+        "The mesh is watertight (okay, valid).";
+
+    std::string cntMsg = ssprintf("\n\nThe model contains %d triangles, from "
+                    "%d surfaces.", g->displayMesh.l.n, g->runningShell.surface.n);
+
+    if(SS.nakedEdges.l.n == 0) {
+        Message("%s\n\n%s\n\nZero problematic edges, good.%s",
+            intersMsg, leaksMsg, cntMsg.c_str());
+    } else {
+        Error("%s\n\n%s\n\n%d problematic edges, bad.%s",
+            intersMsg, leaksMsg, SS.nakedEdges.l.n, cntMsg.c_str());
+    }
+}
+
 void SolveSpaceUI::MenuHelp(Command id) {
     switch(id) {
         case Command::WEBSITE:

diff --git a/src/solvespace.h b/src/solvespace.h
@@ -880,6 +880,7 @@ class SolveSpaceUI {
     bool PruneGroups(hGroup hg);
     bool PruneRequests(hGroup hg);
     bool PruneConstraints(hGroup hg);
+    static void ShowNakedEdges(bool reportOnlyWhenNotOkay);
 
     enum class Generate : uint32_t {
         DIRTY,