Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner ad size extra large #180

Closed
imtiaz791 opened this issue Sep 13, 2021 · 15 comments
Closed

Banner ad size extra large #180

imtiaz791 opened this issue Sep 13, 2021 · 15 comments
Labels
solved Developer confirm that issue solved.

Comments

@imtiaz791
Copy link

Hi,
I am use banner 320*50 size but ad cover half screen of mobile phone. I use "HMSUnityPackageV2.0.8-2019-2020".
Please help me.
Thanks,
Screenshot 2021-09-09 061459
@sametguzeldev
Copy link
Collaborator

Hello there. This is a known bug at the moment with HMS Ads SDK and has been reported to Huawei Mobile Services.

@sametguzeldev sametguzeldev added the bug Something isn't working label Sep 13, 2021
@alijaffer
Copy link

I am also facing in latest plugin. In Portrait mode banner works fine but in landscape mode it covers almost half screen. and our games are being rejected due to this issue.

WhatsApp.Video.2021-12-10.at.17.12.56.mp4

@sametguzeldev
Copy link
Collaborator

I am also facing in latest plugin. In Portrait mode banner works fine but in landscape mode it covers almost half screen. and our games are being rejected due to this issue.

WhatsApp.Video.2021-12-10.at.17.12.56.mp4

Hello @alijaffer.
I will try the latest version of HMS Ads kit and see if it's resolved. If you want to fix it right now, please see this comment to fix it.

@alihan98ersoy alihan98ersoy added the investigating We are investigating the current problem label Apr 12, 2022
@alihan98ersoy alihan98ersoy mentioned this issue Jun 15, 2022
Merged
alihan98ersoy added a commit that referenced this issue Jun 17, 2022
@alihan98ersoy
BannerAds extra large & BannerAds left-right not working & in positio…
102579c 
…n top not positioned within the safe area issues fixed (#331)

#180 BannerAds extra large
#128 BannerAds left-right not working
#129 position top is not positioned within the safe area
issues fixed

Now users can create custom size banner ads
BannerView height is limited to fix banner size extra large when Landscape
@alihan98ersoy
Copy link
Collaborator

We fixed the issue with the new version.

@alihan98ersoy alihan98ersoy added waiting for confirmation The solution has been given and removed bug Something isn't working investigating We are investigating the current problem labels Jun 20, 2022
alihan98ersoy added a commit that referenced this issue Jun 20, 2022
@alihan98ersoy
V2.2.3 2018 (#333)
1eaf2b0 
* Update VERSION V2.2.3(#332)

#180 BannerAds extra large
#128 BannerAds left-right not working
#129 position top is not positioned within the safe area
issues fixed

Now users can create custom size banner ads
BannerView height is limited to fix banner size extra large when Landscape

Applinking and In-App comment added
@imtiaz791
Copy link
Author

the issue is fixed, Thanks,

@alihan98ersoy alihan98ersoy added solved Developer confirm that issue solved. and removed waiting for confirmation The solution has been given labels Jun 20, 2022
@VeljkoLukic
Copy link

I am facing the same issue in landscape mode using 2.2.3 version of the plugin, even though it says it's fixed

Is there any more information about this issue?

@alihan98ersoy alihan98ersoy reopened this Jun 29, 2022
@alihan98ersoy alihan98ersoy added investigating We are investigating the current problem and removed solved Developer confirm that issue solved. labels Jun 29, 2022
@alihan98ersoy
Copy link
Collaborator

alihan98ersoy commented Jun 29, 2022 •
edited

Hello, if you don't mind can you share a screenshot and log with me. And which unity version are you using? What is your test device screen Resolution?

@VeljkoLukic
Copy link

Here is the log and the screenshot > https://drive.google.com/drive/folders/1xKhebV-jfcEyPpJVp7NXDwBIo27GRGMm?usp=sharing

Unity version: 2020.3.31f1
Resolution: 2376x1080px

@alihan98ersoy
Copy link
Collaborator

We added logs with the new update, but I couldn't see those logs in your log. Are you sure you have successfully updated the plugin? If you are sure, I can try to downgrade and upgrade again, but there is already a confirmation that the problem is solved.

@VeljkoLukic
Copy link

I will try and re-import the 2.2.3 package

@alihan98ersoy alihan98ersoy added waiting for confirmation The solution has been given and removed investigating We are investigating the current problem labels Jun 29, 2022
@VeljkoLukic
Copy link

Cleaned up the project and re-imported the plugin, confirming that the banner still takes up 1/3 of the screen

Can you tell me which specific logs to look for in the output?

@alijaffer
Copy link

alijaffer commented Jun 30, 2022 •
edited

I have update the plugin and I can confirm that issue is fixed.. And Also banner Position can be changed .Thanks!!!!!

@alihan98ersoy
Copy link
Collaborator

Cleaned up the project and re-imported the plugin, confirming that the banner still takes up 1/3 of the screen

Can you tell me which specific logs to look for in the output?

resim

resim

I try with a new project and it is working can you test it with a new project If it is work please delete the Huawei folder and then reimport the plugin. (don't forget the backup first)

I believe this file is not updating.
resim

@VeljkoLukic
Copy link

Fixed, thanks!
That was right, app-debug wasn't updated successfully

@alihan98ersoy
Copy link
Collaborator

Don't forget to star our project to support us and join our discord channel to ask your questions easily :)

@alihan98ersoy alihan98ersoy added solved Developer confirm that issue solved. and removed waiting for confirmation The solution has been given labels Jun 30, 2022
alihan98ersoy pushed a commit that referenced this issue Aug 5, 2022
@enes-ozdemir
2.0 2018 v2.2.4 (#348)
7dec68d 
* AppLinling added.

* BannerAds extra large & BannerAds left-right not working & in position top not positioned within the safe area issues fixed (#331)

#180 BannerAds extra large
#128 BannerAds left-right not working
#129 position top is not positioned within the safe area
issues fixed

Now users can create custom size banner ads
BannerView height is limited to fix banner size extra large when Landscape

* DriveKit added (#330)

* IAP demo scene always landscape now

* HMSCore installer SDK added

* Location Kit integration completed.

* Location Kit Demo added.

* Location Kit added to the editor

* Readme updated for location kit

* Scenes are edited for 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
solved Developer confirm that issue solved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sametguzeldev @alijaffer @VeljkoLukic @alihan98ersoy @imtiaz791