Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare version 1.3.0 Added unit tests #167

Merged
merged 4 commits into from
Aug 22, 2019
Merged

Prepare version 1.3.0 Added unit tests #167

merged 4 commits into from
Aug 22, 2019

Conversation

miller45
Copy link
Collaborator

No description provided.

medial querys for larger (screenshot) modal dialogs
e2e spec with third screenshot and one nested log
added unit tests for screenshot navigation
@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #167 into master will increase coverage by 0.32%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   44.08%   44.41%   +0.32%     
==========================================
  Files           3        3              
  Lines        8212     8212              
  Branches     1743     1743              
==========================================
+ Hits         3620     3647      +27     
+ Misses       4592     4565      -27
Impacted Files Coverage Δ
index.js 42.63% <0%> (ø) ⬆️
lib/app.js 80.73% <50%> (+11.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ece08...41a40d7. Read the comment docs.

@miller45 miller45 merged commit 6886c10 into master Aug 22, 2019
@miller45 miller45 deleted the keyboardnav branch August 22, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants