Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails #77

Closed
matsueushi opened this issue Mar 8, 2021 · 3 comments · Fixed by JuliaImages/ImageTransformations.jl#114
Closed

CI fails #77

matsueushi opened this issue Mar 8, 2021 · 3 comments · Fixed by JuliaImages/ImageTransformations.jl#114
Labels

Comments

@matsueushi
Copy link

Hello,

Currently CI is falling, it seems it was caused by the ImageTransformations v0.8.8 release. All tests have passed when I downgraded it to v0.8.7. I guess the commit JuliaImages/ImageTransformations.jl@a4f2190 has changed the result of invwarpedview.

julia> square = [0.1 0.2 0.3; 0.4 0.5 0.6; 0.7 0.6 0.9]
julia> x = Augmentor.prepareaffine(square)
julia> m = Augmentor.toaffinemap(Rotate90(), square)

With ImageTransformations v0.8.7:

julia> Augmentor.invwarpedview(x, m)
3×3 InvWarpedView(extrapolate(interpolate(::Array{Float64,2}, BSpline(Interpolations.Linear())), Flat()), AffineMap([6.123233995736766e-17 -1.0; 1.0 6.123233995736766e-17], [4.0, 0.0])) with eltype Float64 with indices 1:3×1:3:
0.3 0.6 0.9
0.2 0.5 0.6
0.1 0.4 0.7

With ImageTransformations v0.8.8:

julia> Augmentor.invwarpedview(x, m)
4×4 InvWarpedView(extrapolate(interpolate(::Array{Float64,2}, BSpline(Interpolations.Linear())), Flat()), AffineMap([6.123233995736766e-17 -1.0; 1.0 6.123233995736766e-17], [4.0, 0.0])) with eltype Float64 with indices 1:4×1:4:
 0.3  0.6  0.9  0.9
 0.2  0.5  0.6  0.6
 0.1  0.4  0.7  0.7
 0.1  0.4  0.7  0.7
@johnnychen94
Copy link
Collaborator

Yeah, the result looks really wrong here. I'm not sure if I have the time to investigate this, would you help figure out what should be fixed here?

@matsueushi
Copy link
Author

Okay, I'll take a look.

@matsueushi
Copy link
Author

I made a PR related to this issue on ImageTransformations.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants